New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(selection): update logic to fix selection of disabled rows #5401

Open

simcha90 wants to merge 3 commits into TanStack:main from simcha90:fix-disabled-selection

simcha90 commented Mar 10, 2024 •

edited

Fix issue:

We updated logic for selection of disabled rows (at least for pagination).

Here next possible flows:

One row disabled and selected then click on Footer checkbox:

if all other rows selected - Footer checkbox: SELECTED
if all other rows unselected - Footer checkbox: INDETERMINATE

One row disabled and unselected then click on Footer checkbox:

if all other rows selected - Footer checkbox: INDETERMINATE
if all other rows unselected - Footer checkbox: UNSELECTED

One row disabled and selected and One row disabled and unselected then click on Footer checkbox:

if all other rows selected - Footer checkbox: INDETERMINATE
if all other rows unselected - Footer checkbox: INDETERMINATE

Status of all enabled checkboxes always will be toggled, but sign inside Footer checkbox will show real state of all checkboxes

P.S. Also getToggleAllRowsSelectedHandler respect disabled checkboxes

simcha90 added 3 commits

March 10, 2024 10:33


fix(selection): update logic to fix selection of disabled rows

aa09274


fix(selection): update logic to fix selection of disabled rows

5f25ff9


fix(selection): update logic to fix selection of disabled rows

173e6e9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment