fix: assign parentId to subRows when creating aggregatedRows #4882
Conversation
| @@ -118,6 +118,10 @@ export function getGroupedRowModel<TData extends RowData>(): ( | |||
| }) | |||
|
|
|||
| subRows.forEach(subRow => { | |||
| if (!subRow.parentId) { | |||
| Object.assign(subRow, { parentId: id }); | |||
There was a problem hiding this comment.
Unfortunately, this also introduces a bug where the table will crash after ungrouping by a column. Needs to be looked into more, but this will be part of the solution.
There was a problem hiding this comment.
Good catch Kevin. I was so focused on the solution for my current use-case that I forgot about ungrouping 😢
There was a problem hiding this comment.
Looking into it, we have to find a way to remove the parentId as we ungroup.
There was a problem hiding this comment.
I'm trying to navigate this code, trying to follow the same approach for how the .depth value is assigned/unassigned.. But I see that property being modified in here:
So, I have couple questions:
- What is the difference between and the section I touched on this PR? mostly, they seem the same, but not sure why they happen in two diff places
table/packages/table-core/src/utils/getGroupedRowModel.ts
Lines 38 to 41 in 46b160d
- Would that better a place to assign/unassign the
parentId🤔?
There was a problem hiding this comment.
😞 well, depth is also wrong
ungrouping the column keeps the rows depth: 1; 🛑
but they should go back to depth: 0 which is the expected value when ungrouped 🤕
There was a problem hiding this comment.
For what is worth:
assigning/un-assigning depth in v7 works just fine, here an example: https://codesandbox.io/s/amazing-water-pcepcv?file=/src/App.js
|
This is still an important bug fix. Will be looking into how to fix the ungrouping crash |
I'm sorry I let this PR stale. Work has been insane last months, that I haven't had the time to work on any of this |
Fixes #4881