chore: add solid export condition to @tanstack/solid-form
#631
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solid relies on the solid export condition to perform a custom JSX transform depending on whether the code is being built for client or server, but
@tanstack/solid-form
only hasdist/cjs
anddist/esm
, which are client-only since they import stuff likememo
fromsolid-js/web
(which is only available in client builds).To fix this I've added
tsc
to the build of process of@tanstack/solid-form
so that.js/.jsx
files are emitted which solid can apply its custom JSX transform on. There's probably nicer ways of doing this that can integrate with vite but this is what I did to fix a similar problem for SolidStart.