Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My sqldml #252

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

sushantkumbhar
Copy link

What kind of change does this PR introduce? (check one with "x")

[x] Bugfix
[] Feature- This activity provides your flogo application the ability to fire a select, update, Delete and insert queries to MYSQL database.
[x] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[x] Other... Please describe:

Fixes: #

What is the current behavior?
As per Current behaviour, In Flogo only MySQL Select query activity is available.
What is the new behavior?
This feature will help to fire select, update, Delete and insert queries to MYSQL database using single code.

@sushantkumbhar
Copy link
Author

Waiting for the reviews

@retgits
Copy link
Contributor

retgits commented Jul 25, 2018

Hi! Thanks for the PR, but could you make sure all the references are correct (for example the "ref" field points to the GitHub repository of another person). Also, could you make sure the return type is a JSON object ("any" type) instead of a string? That would make the mapping in other activities a lot easier

@sushantkumbhar
Copy link
Author

Hi Sir, thank you for the feedback. I have done the changes please check.

@sushantkumbhar
Copy link
Author

please accept the pull request.

@mellistibco
Copy link
Collaborator

Hi @sushantkumbhar sorry! I'll take a look and merge.

@sushantkumbhar
Copy link
Author

Hi, Can you please update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants