Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Stella as A2600 emulation core #3911

Open
wants to merge 26 commits into
base: master
Choose a base branch
from

Conversation

SergioMartin86
Copy link
Contributor

@SergioMartin86 SergioMartin86 commented May 3, 2024

Adding Stella as A2600 emulator.

Progress has been painful and messy; don't expect minimalism during this first stage. We can do the fine tuning once everything works correctly.

Check if completed:

  • I have run any relevant test suites

  • I, the committer, have read the licensing terms for contributors (last updated 2024-03-20) and am compliant

  • Load Rom

  • Advancing Frame

  • Processing Digital Inputs

  • Processing Analog Inputs

  • Rendering frame into the screen

  • Rendering sound

  • Memory Accesses

  • CPU Hooks

@CasualPokePlayer
Copy link
Member

Note, GPGX isn't particularly the best example of how to do a waterbox core, if it's at all possible use the standard WaterboxCore base class (see PicoDrive, TIC80, uzem, as simple examples of this being used)

@SergioMartin86
Copy link
Contributor Author

Ok, opening this PR for review. This is a summary of what's been done:

  • Emulation works correctly for several games I tested (including Myst, which apparently a2600hawk does not support)
  • Video is rendering correctly
  • Audio is also playing correctly, except for the first few frames or so (try Frogger (USA).a26)
  • Statable interface correctly implemented
  • Memory domains correctly showing
  • Digital Controllers working

To-Dos:

  • Analog controllers (paddle) not currently supported
  • CPU hooks and debug functonality not current implemented

@SergioMartin86 SergioMartin86 marked this pull request as ready for review May 9, 2024 08:58
#include "M6532.hxx"
#include "TIA.hxx"

uint16_t soundbuffer[4096];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be placed in the invisible section?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that'd make sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants