Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace UniformInfos with init-only UniformInfo #3883

Closed
wants to merge 1 commit into from

Conversation

Morilli
Copy link
Collaborator

@Morilli Morilli commented Mar 28, 2024

Seems like a simple simplification of the code, but I'm not sure if it could break anything.

Check if completed:

@CasualPokePlayer
Copy link
Member

FWIW, this would break things for D3D9 where the vertex and pixel shaders both have uniforms of the same name (for OpenGL these are just considered the same, hence Sole existing, but for D3D land these are considered separate uniforms).

Isn't relevant anymore since the code was entirely refactored.

@Morilli Morilli deleted the remove-uniforminfos branch May 20, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants