Better Firmware Names #3766
Open
Better Firmware Names #3766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renaming Firmware Files based on System Name as BizHawk uses or at least renamed to be related to what it's for.
hegyak
added
App: EmuHawk
This comment was marked as resolved.
This comment was marked as resolved.
PC-Engine, Vectrex, Lynx, MSX And resolve Name Collision, Odyssey 2 G7400, Gameboy, GameBoy Color.
|
I do not get why the Commit I made is changing the Line Endings. But I have redone the changes. That unifies the names for all the Firmware. |
Comment on lines
+113
to
+114
| FirmwareAndOption("79F5FF55DD10187C7FD7B8DAAB0B3FFBD1F56A2C", 262144, "PCECD", "Bios", "NEC_PCECD_3.0-(J).pce", "Super CD Bios (J)"); | ||
| FirmwareAndOption("014881A959E045E00F4DB8F52955200865D40280", 32768, "PCECD", "GE-Bios", "NEC_PCECD_gecard.pce", "Games Express CD Card (Japan)"); |
There was a problem hiding this comment.
NEC is a manufacturer name, not a console name.
Comment on lines
+191
to
+193
| FirmwareAndOption("409E82ADAC40F6BDD18EB6C84E8B2FBDC7FB5498", 32768, "MSX", "bios_basic_usa", "Microsoft_MSX.rom", "MSX BIOS and BASIC"); | ||
| FirmwareAndOption("3656BB3BBC17D280D2016FE4F6FF3CDED3082A41", 32768, "MSX", "bios_basic_usa", "Microsoft_MSX_1.0.rom", "MSX 1.0 BIOS and BASIC"); | ||
| FirmwareAndOption("302AFB5D8BE26C758309CA3DF611AE69CCED2821", 32768, "MSX", "bios_basic_jpn", "Microsoft_MSX_jpn.rom", "MSX 1.0 JPN BIOS and BASIC"); |
There was a problem hiding this comment.
Microsoft is not a part of the device name.
|
I'd forgotten about #2204, but this is a follow-up to that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renaming Firmware Files based on System Name as BizHawk uses or at least renamed to be related to what it's for.
This changes the Auto-Renamed Firmware Files to be named based on the System ID.
Or to be more Descriptive. So the users can see helpful file names.
The File has been formatted to use LF instead of CRLF. Which is why it feels like a "Full Replacement"
Examples of Old Name:
cx4.rom
KoF95.bin
Examples of New Name:
SNES_cx4.rom
SAT_KoF95.bin
Also changed the MSX 1.0 BIOS and BASIC vs MSX BIOS and BASIC have their own filenames now instead of a Filename Collision.
Check if completed: