Added support for Tools.GeneralUpdate() in MainForm #3723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
ToolManagerdoes not haveGeneralUpdate()exposed in theMainFormclass. I added very minimal changes and added theGeneralUpdate()function, so that when BizHawk is running, the emulation is paused, TAStudio is opened, and an external tool is loaded and opened, the external tool can finally be able to update by overridingToolFormBase.GeneralUpdate()and do things in the background without the requirements of having to frame advance or unpause the emulation.Check if completed:
GeneralUpdate()when correctly implemented).Should be able to close #3626 .