Sanitize text pasted into hex text boxes #3684
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalimag
commented
Jun 17, 2023
src/BizHawk.Client.EmuHawk/CustomControls/ClipboardEventTextBox.cs
Outdated
Show resolved
Hide resolved
kalimag
commented
Jun 17, 2023
kalimag
commented
Jun 18, 2023
src/BizHawk.Client.EmuHawk/CustomControls/ClipboardEventTextBox.cs
Outdated
Show resolved
Hide resolved
|
Does this specifically break any functionality on unix? or just fail to add new functionality? If it is the former, I say we merge this |
YoshiRulz
requested changes
May 7, 2024
| @@ -435,6 +437,21 @@ protected override void OnTextChanged(EventArgs e) | |||
| base.OnTextChanged(e); | |||
| } | |||
|
|
|||
| protected override void OnPaste(PasteEventArgs e) | |||
There was a problem hiding this comment.
(ditto of everything that applies to other impl.)
| int availableLength = MaxLength - TextLength + SelectionLength; | ||
| if (text.Length > availableLength) | ||
| { | ||
| text = text.Substring(0, availableLength); |
There was a problem hiding this comment.
Style nitpicks: Add argument names here, use var everywhere, use is for enum/const comparison, use string.Empty, and make PasteEventArgs sealed.
src/BizHawk.Client.EmuHawk/CustomControls/ClipboardEventTextBox.cs
Outdated
Show resolved
Hide resolved
Trim `0x` and `$` prefixes and whitespace pasted into `HexTextBox` and `WatchValueBox`. Prevent pasting non-hex text. Add `ClipboardEventTextBox` control with `OnPaste` event
kalimag
force-pushed
the
pr/sanitize-hex-paste
branch
from
c494fd8
to
40dce63
Compare
YoshiRulz
reviewed
May 8, 2024
YoshiRulz
reviewed
May 14, 2024
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
ClipboardEventTextBoxcontrol with anOnPastemethod and makeHexTextBoxandWatchValueBoxinherit from thatOverride normal paste behavior to trim
0x/$/whitespace from pasted textPrevent pasting of non-hex text
Resolves #3682