Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[F.Rq.] Allow pasting 0xHHHH-formatted numbers in a HexTextBox (e.g. in WatchEditor) #3682

Closed
YoshiRulz opened this issue Jun 13, 2023 · 2 comments · Fixed by #3684
Closed

[F.Rq.] Allow pasting 0xHHHH-formatted numbers in a HexTextBox (e.g. in WatchEditor) #3682

YoshiRulz opened this issue Jun 13, 2023 · 2 comments · Fixed by #3684
Labels
App: EmuHawk Relating to EmuHawk frontend Enhancement For feature requests or possible improvements

Comments

@YoshiRulz
Copy link
Member

Went to add Ctrl+V check to keydown handler, but I have no idea what these magic numbers are. Official docs (current) were no help, nor was StackOverflow.

BizHawk/src/BizHawk.Client.EmuHawk/CustomControls/HexTextBox.cs

Lines 70 to 75 in 13dd04a

protected override void OnKeyPress(KeyPressEventArgs e)
{
if (e.KeyChar == '\b' || e.KeyChar == 22 || e.KeyChar == 1 || e.KeyChar == 3)
{
return;
}

@YoshiRulz YoshiRulz added Enhancement For feature requests or possible improvements App: EmuHawk Relating to EmuHawk frontend labels Jun 13, 2023
@Morilli
Copy link
Collaborator

Morilli commented Jun 13, 2023

I'm in favor of removing all that custom logic and just doing a simple check for validity after the user is finished entering the number, like in c78c0c3

@kalimag
Copy link
Contributor

kalimag commented Jun 17, 2023

Supporting the $HH format used by most (dis)assemblers would also be nice to have.

Same goes for trimming whitespace before truncating the length.

@kalimag kalimag mentioned this issue Jun 17, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
App: EmuHawk Relating to EmuHawk frontend Enhancement For feature requests or possible improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sanitize text pasted into hex text boxes kalimag/BizHawk
3 participants
@YoshiRulz @kalimag @Morilli