Support Phantom wallet #698

maximgeerinck · 2023-04-07T08:17:17Z

Motivation and context

Add support for phantom wallet.

List of current features:

Connect wallet
Sign message
Cancel signing
Wallet setup
Copy eth address

EXTRA:

Multiple providers: Can use metamask and phantom together in 1 session using the PROVIDERS environment variable
Supports versions using @

PROVIDERS=phantom,[email protected] npx playwright test

TODO:

Phantom to provide public releases (Right now only accessible by providing strongly protected PATs)

Quality checklist

I have performed a self-review of my code.

Future Ideas

Would be nice if these providers can be classes that extend from an abstract class
We will look into more generic selectors (like proxying getByText, ... for accessing more generic things in dialogs)
Typescript support

neuodev · 2023-04-20T00:04:24Z

Hello, @maximgeerinck 👋

If I am getting it correctly this Phantom Wallet support PR is not finished because there is no way to download phantom wallet as it's not open-source. The plan from your side was to wait until it is open-sourced.

Just want to let you know that you can use this chrome extension to extract the source code from any chrome extension as ZIP file.

Also, you can use this website to download the source code.

Also, check this GitHub gist on how to download the source code for any Chrome extension.

CRX Viewer will allow you to download the source code for any Chrome extension (repo)

Thanks, please let me know if you need any help!

maximgeerinck · 2023-06-08T12:44:30Z

We've added a way to download a phantom crx and install it

neuodev

Many tests are failing when running PROVIDERS=phantom,[email protected] pnpm run test:e2e

plugins/index.js

commands/metamask.js

@@ -1332,13 +1490,14 @@
 await metamask.goToAdvancedSettings();
 }
 }
- if ((await playwright.metamaskWindow().locator(toggleOn).count()) === 0) {
- await playwright.waitAndClick(toggleOff);
+ if (!(await playwright.windows(PROVIDER).locator(toggleOn).count()) === 0) {


duckception · 2023-09-09T16:11:15Z

commands/phantom.js

@@ -0,0 +1,551 @@
+const log = require('debug')('synpress:phantom');


Suggested change

const log = require('debug')('synpress:phantom');

support/commands.js

neuodev · 2023-06-15T22:14:53Z

@maximgeerinck Tests are failing due to the recent changes (mostly adding new networks), can you please take a look? Many thanks for considering my request.

commands/playwright.js

neuodev · 2023-06-16T15:11:48Z

package.json

+ "name": "@phantom/synpress",
+ "version": "4.0.0-alpha.22",


Suggested change

"name": "@phantom/synpress",

"version": "4.0.0-alpha.22",

"name": "@synthetixio/synpress",

"version": "3.7.0",

duckception

A little bit late, but here's the initial review 🫡

.eslintrc.js

duckception · 2023-08-28T12:51:00Z

package.json

@@ -114,6 +115,9 @@
 "ansi-regex": "5.0.1",
 "@testing-library/dom": "8.20.0"
 },
+ "overrides": {


Why do we override lodash here?

there were some instances were an insecure version of lodash is used in dependencies, this overrides it

package.json

commands/metamask.js

duckception · 2023-09-09T16:05:31Z

commands/playwright.js

 return browser.isConnected();
 },
+ clearExtensionData: async provider => {


Any particular reason why this function was introduced?

for solana dapps this is needed as this is the only proper way to stop auto connecting

plugins/index.js

duckception · 2023-09-09T16:33:14Z

plugins/index.js

- );
- arguments_.extensions.push(metamaskPath);
+ if (process.env.PROVIDERS) {
+ process.env.CYPRESS_PROVIDERS = process.env.PROVIDERS;


Why do we set this here?

cause cypress only recognizes env vars that start with CYPRESS_

plugins/index.js

helpers.js

duckception · 2023-09-09T16:42:54Z

plugins/index.js

+ activateShowCustomNetworkListInMetamask: async skipSetup => {
+ const activated = await getProvider(
+ selectedProvider,
+ ).activateShowCustomNetworkList(skipSetup);


What happened here?

nothing much, just using providers now

I mean that activateImprovedTokenAllowanceInMetamask function was replaced by activateShowCustomNetworkListInMetamask. Curious what happened here

ok, will put that back

duckception · 2023-09-19T21:26:05Z

Two crucial things:

MetaMask tests are broken. They need to be fixed. Once this is done, I'll approve workflows on CI.
Add similar tests for Phantom.

duckception

Rebase looks good 👍🏻 I think we only need working tests for both of the wallets and we can merge this 🫡

feat: Add switch account

vercel · 2024-01-25T16:34:11Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
synpress	❌ Failed (Inspect)			Jan 26, 2024 3:15pm

fix: Fix preferences for default wallet navigation

vercel · 2024-03-01T15:39:27Z

@maximgeerinck is attempting to deploy a commit to the Synpress Team on Vercel.

A member of the Team first needs to authorize it.

neuodev requested review from neuodev and drptbl April 7, 2023 22:52

neuodev self-assigned this Apr 7, 2023

maximgeerinck and others added 14 commits June 8, 2023 14:45

feat: Make sure onboarding a wallet works

e3371b5

chore: Add phantom selectors

25b3b4c

chore: Adjust timings

cdde119

chore: Phantom download

0d11954

chore: Support phantom 3.6.0

1e43761

feat: Add multi provider support

f7d1900

v4.0.0-alpha.1

0878ca1

chore: provider leftovers

0523b94

chore: Add new phantom welcome screen

8798a22

Add disconnectWalletFromDapp method and selectors

8fea081

wip

f796d90

chore: Add more selectors + remove PAT

be1b371

fix: wrong window names

cf7e85e

chore: Add phantom crx downloader

b70022e

maximgeerinck force-pushed the dev branch from fe136c6 to b70022e Compare June 8, 2023 12:59

maximgeerinck added 2 commits June 8, 2023 16:25

chore: update lockfile

d690912

chore: align initialSetup with metamask

3fdd8e8

maximgeerinck marked this pull request as ready for review June 9, 2023 09:36

neuodev reviewed Jun 15, 2023

View reviewed changes

plugins/index.js Outdated Show resolved Hide resolved

plugins/index.js Outdated Show resolved Hide resolved

plugins/index.js Outdated Show resolved Hide resolved

github-advanced-security bot found potential problems Jun 15, 2023

View reviewed changes

neuodev reviewed Jun 15, 2023

View reviewed changes

support/commands.js Outdated Show resolved Hide resolved

neuodev reviewed Jun 15, 2023

View reviewed changes

commands/playwright.js Show resolved Hide resolved

neuodev mentioned this pull request Jun 15, 2023

feat: clear extension data #787

Closed

2 tasks

neuodev reviewed Jun 16, 2023

View reviewed changes

duckception self-requested a review August 25, 2023 23:38

duckception suggested changes Sep 9, 2023

View reviewed changes

maximgeerinck added 2 commits September 19, 2023 15:27

Merge remote-tracking branch 'upstream/dev' into dev

affae02

wip

a08518f

maximgeerinck force-pushed the dev branch from e55f98e to b40f6c8 Compare September 20, 2023 11:23

chore: rebase fixes

f30bbfd

maximgeerinck force-pushed the dev branch from b40f6c8 to f30bbfd Compare September 20, 2023 11:27

chore: Update metamask v11

26bd100

maximgeerinck force-pushed the dev branch from 2a426e8 to 26bd100 Compare September 20, 2023 12:08

maximgeerinck requested review from neuodev and duckception September 21, 2023 08:01

duckception suggested changes Sep 21, 2023

View reviewed changes

rafinskipg added 3 commits January 25, 2024 16:47

feat: Add switch account

13836fe

Use selectors

555ffbd

Merge pull request #13 from phantom/feat/switch-accounts

8ed316f

feat: Add switch account

vercel bot had a problem deploying to Preview January 25, 2024 16:34 Failure

release: alpha.30

fc05644

vercel bot had a problem deploying to Preview January 26, 2024 08:39 Failure

rafinskipg and others added 2 commits January 26, 2024 15:57

Fix preferences

3f469d1

Merge pull request #14 from phantom/fix/preferences

d8c4490

fix: Fix preferences for default wallet navigation

vercel bot had a problem deploying to Preview January 26, 2024 15:14 Failure

release: alpha-31

2927df1

vercel bot had a problem deploying to Preview January 26, 2024 15:15 Failure

fix: Flaky continue button

c2b7e67

maximgeerinck added 3 commits March 30, 2024 11:35

fix: unlock

9875fbb

fix: interstitial login

05237d7

fix: remove pause

6ba9812

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support Phantom wallet #698

Support Phantom wallet #698

maximgeerinck commented Apr 7, 2023 •

edited

neuodev commented Apr 20, 2023

maximgeerinck commented Jun 8, 2023

neuodev left a comment

duckception Sep 9, 2023

neuodev commented Jun 15, 2023

neuodev Jun 16, 2023

duckception left a comment

duckception Aug 28, 2023

maximgeerinck Sep 19, 2023 •

edited

duckception Sep 9, 2023

maximgeerinck Sep 19, 2023

duckception Sep 9, 2023

maximgeerinck Sep 19, 2023

duckception Sep 9, 2023

maximgeerinck Sep 19, 2023

duckception Sep 19, 2023

maximgeerinck Sep 21, 2023

duckception commented Sep 19, 2023

duckception left a comment

vercel bot commented Jan 25, 2024 •

edited

vercel bot commented Mar 1, 2024

		@@ -0,0 +1,551 @@
		const log = require('debug')('synpress:phantom');

Support Phantom wallet #698

Are you sure you want to change the base?

Support Phantom wallet #698

Conversation

maximgeerinck commented Apr 7, 2023 • edited

Motivation and context

Quality checklist

Future Ideas

neuodev commented Apr 20, 2023

maximgeerinck commented Jun 8, 2023

neuodev left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

neuodev commented Jun 15, 2023

Choose a reason for hiding this comment

duckception left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

maximgeerinck Sep 19, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

duckception commented Sep 19, 2023

duckception left a comment

Choose a reason for hiding this comment

vercel bot commented Jan 25, 2024 • edited

vercel bot commented Mar 1, 2024

maximgeerinck commented Apr 7, 2023 •

edited

maximgeerinck Sep 19, 2023 •

edited

vercel bot commented Jan 25, 2024 •

edited