Stop transitively depending on Cypress #1100
Open
+9
−107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a design limitation in DefinitelyTyped, it doesn't support `peerDependencies`. This means that Synpress, even when used with Playwright, transitively depends on Cypress, and installs it for its users. PRs that try to fix it get closed: - DefinitelyTyped/DefinitelyTyped#67000 (review) - DefinitelyTyped/DefinitelyTyped#44962 I moved `@types/testing-library__cypress` to `peerDependencies`.
|
@hasparus is attempting to deploy a commit to the Synpress Team on Vercel. A member of the Team first needs to authorize it. |
|
Thanks for PR @hasparus! We're currently working on new version of synpress (currently in alpha) which already fixes mentioned issue. Nevertheless I will considering merging this to stable version of synpress asap. 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! Firstly, thank you for Synpress. I've been using it for end-to-end tests of Subgraph Studio for a while already.
Motivation and context
Due to a design limitation in DefinitelyTyped, it doesn't support
peerDependencies. This means that Synpress, even when used with Playwright, transitively depends on Cypress, and installs it for its users.This is an issue, because installing Cypress means downloading a browser. It's not fast, and with it can fail with a socket timeout on flaky internet connections.
PRs that try to fix it get closed:
@testing-library/cypressDefinitelyTyped/DefinitelyTyped#44962Does it fix any issue?
Not that I know of.
Quality checklist