Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Vue 3 #505

Merged
merged 34 commits into from
Dec 8, 2023
Merged

Migrate to Vue 3 #505

merged 34 commits into from
Dec 8, 2023

Conversation

haniAljti
Copy link
Contributor

  • upgraded vue 2 to vue 3 using vue 3 compat
  • updated and added a wrapper for Ui-toast-editor since the wrapper does not support vue 3 but it should function the same way.
  • there is no update for "vue2-interact" that works on vue 3 but i've built the same functionality using Hammerjs. (I tested it. but it would be better if anyone tested it more)
  • the project uses pinia instead of vuex now. Which should also solve Fontend: migrate from vuex to Pinia #212
  • updated other dependancies to use vue 3

Copy link
Member

@stritti stritti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just reviewed sources. Not tested live yet.

Really great work @haniAljti !

frontend/src/components/KickUserWrapper.vue Outdated Show resolved Hide resolved
frontend/src/components/KickUserWrapper.vue Outdated Show resolved Hide resolved
@SponsoredByPuma
Copy link
Contributor

Hey @haniAljti,
nice work overall. 😄
The problems I've noticed are:

  • the jira Component doesn't work anymore ( the b-modal is not showing up anymore)
  • trying to create a session with imported user stories breaks the project, resulting in these error messages:
    image
  • creating a session, where the host can vote as well does not work anymore
    image
    (this is probably a problem of the props & params of the prepare & session page). All of the params are undefined in the session page

The rest looks good. Really nicely done :)

@haniAljti
Copy link
Contributor Author

Thanks. I will take a look.

- admin can vote
- editor breaks
- jira Component modal not showing
@haniAljti
Copy link
Contributor Author

haniAljti commented Nov 10, 2023

Hi @SponsoredByPuma, Please test if this fixes the issues you mentioned. Im not connected to Jira so i can't test that.

@SponsoredByPuma
Copy link
Contributor

I had to remove the radio buttons on the prepare Page since i got the same bug as here: bootstrap-vue/bootstrap-vue#7182

@SponsoredByPuma
Copy link
Contributor

also had to remove the auto input component since selecting a project didnt work and also typing in the input field was impossible.

@SponsoredByPuma SponsoredByPuma merged commit 8977ca8 into Sybit-Education:main Dec 8, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frontend: upgrade to vue 3
3 participants