Removed extra conditions in _auto_identify_connection_string method

[ChandanChainani]

Description

Moved uri string validation case on the start and remove additional conditions as it seem unnecessary

Related Issues

ISSUE: NA

Checklist

• Is this code covered by new or existing unit tests or integration tests?
• Did you run make unit-testing and make integration-testing successfully?
• Do new classes, functions, methods and parameters all have docstrings?
• Were existing docstrings updated, if necessary?
• Was external documentation updated, if necessary?

[blythed]

Hi @ChandanChainani thanks for the PR. Are you sure that these can be dropped like this? Do you get passing tests?

[ChandanChainani]

Hi @blythed, Yes, except for llm and doc_string related test all the other tests are validated

Command

pytest ./test/unittest/ -svv --ignore=test/unittest/ext/test_llama_cpp.py --ignore=test/unittest/ext/llm --ignore=test/unittest/ext/transformers/test_llm.py --ignore=test/unittest/ext/transformers/test_llm_training.py --ignore=test/unittest/ext/transformers/test_transformers.py

Output

=============================================== short test summary info ===============================================
=============================================== short test summary info ===============================================
FAILED test/unittest/cli/test_cli.py::test_cli_info - subprocess.CalledProcessError: Command '('python', '-m', 'superduperdb', 'info')' returned non-zero exit status 1.
ERROR test/unittest/backends/ibis/test_query.py::test_renamings - NotADirectoryError: [WinError 267] The directory name is invalid: 'C:\\Users\\...\\AppData\\Local\\Temp\\tmpi9bnoy_0\\test.ddb'
=========================== 1 failed, 194 passed, 1112 skipped, 1 error in 85.44s (0:01:25) ===========================```

[ChandanChainani]

@blythed

I have update the code and there is one additional condition that I think can be added which is to make sure the user only supply supported db/file uri format please suggest (for supported db/file format we can maintain constants)

[jieguangzhou]

Hey @ChandanChainani , we need to check this pattern, because re_match(r'^[a-zA-Z0-9]+://', 'mongodb+srv://') is None == Ture, then will raise an error.

[jieguangzhou]

please use re.match

[jieguangzhou]

@ChandanChainani Thanks for your PR, Please update the CHANGELOG file, and update the review comments, we will merge the PR after the CI passes, thanks