Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the other ibis from the pyproject.toml #1999

Closed

Conversation

lostmygithubaccount
Copy link

hello, I believe the use of ibis -- a Jinja templating framework thing -- and not ibis-framework, the portable Python dataframe library

this just removes that line, not sure if it's sufficient

Description

Related Issues

Checklist

  • Is this code covered by new or existing unit tests or integration tests?
  • Did you run make unit-testing and make integration-testing successfully?
  • Do new classes, functions, methods and parameters all have docstrings?
  • Were existing docstrings updated, if necessary?
  • Was external documentation updated, if necessary?

Additional Notes or Comments

hello, I believe the use of `ibis` -- a Jinja templating framework thing -- and not `ibis-framework`, the portable Python dataframe library

this just removes that line, not sure if it's sufficient
@jieguangzhou
Copy link
Collaborator

@lostmygithubaccount Hey, thanks, could you help to update te CHANGELOG file? The CI checks the CHANGELOG for every PR

@blythed
Copy link
Collaborator

blythed commented May 13, 2024

Thank-you @lostmygithubaccount! We solved this in another PR - thanks for pointing out!

@blythed blythed closed this May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants