Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed command output in makePDF.py #280

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

0ssifrage
Copy link

" ".join(cmd) may be different from the command it really runs.
It may mislead users who have problem compiling the tex file, so I suggest replace the code with subprocess.list2cmdline(cmd)

@msiniscalchi
Copy link
Contributor

Oops! OK, thanks!

On Thu, Dec 5, 2013 at 10:27 PM, Charley Peng [email protected]:

Seems like this is a function that should not be used externally, as per,
http://bugs.python.org/issue11827.

That function does not appear in the Python 3.3 documentation.


Reply to this email directly or view it on GitHubhttps://github.com//pull/280#issuecomment-29962852
.

Marciano Siniscalchi
Economics Department, Northwestern University
http://faculty.wcas.northwestern.edu/~msi661

@0ssifrage
Copy link
Author

Thanks, but I still suggest that " ".join(cmd) should be replaced by some functions.

(When I compiled the tex file with Chinese characters in the path, it returned the command without some necessary quotes, which made me think that there is something wrong when generate the command. So I checked the code for a long time, only to find that the command it run was fine but the command it displayed had minor mistakes. The reason why I couldn't compile the tex file was the xelatex command doesn't support Chinese characters well.)

So I suggest to display the command in another way or just let it don't display the command (because the probability of error that could not compile is very small, and the wrong command displayed is not very useful.)

@ig0774 ig0774 force-pushed the master branch 3 times, most recently from 3041ae1 to 9a86aef Compare July 10, 2016 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants