Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip quotes from filename when analyzing for cache #1267

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sethblumberg
Copy link

This commit strips any surrounding doublequotes from each filename that is added to the cache.

Files with spaces in the filename need surrounding quotes for \input{} to work. With this change, things like labels inside them will show up in the reference autocomplete pop-up list.

This change isn't comprehensive, so feel free to write a better one. For example, C+l,C_o (to open a file if it exists, or make a new one if it doesn't exist) still trips up on quotes surrounding a filename.

Filenames with spaces in a multi-file LaTeX project may be written surrounded in doublequotes.  This commit allows these files to be searched for the cache, so things like ref autocomplete will make use of their contents.
@r-stein
Copy link
Member

r-stein commented Dec 11, 2017

Sounds reasonable. I will have a look at it in the next days.

@sethblumberg
Copy link
Author

I made a similar change in jumpto_tex_file.py over in pull request 1270. They're separate because I didn't know how to add another change to this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants