Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[needs websockets] Add development flake file #620

Merged
merged 4 commits into from May 12, 2024

Conversation

PartyWumpus
Copy link
Member

Please tick as appropriate:

  • I have tested this code on a steam deck or on a PC
  • My changes generate no new errors/warnings
  • This is a bugfix/hotfix
  • This is a new feature

If you're wanting to update a translation or add a new one, please use the weblate page: https://weblate.werwolv.net/projects/decky/

Description

Adds a flake.nix file so developers can get all relevant dependencies by just typing nix develop.
Uses poetry2nix so all python deps will get installed at the correct versions without needing to update the flake.
It's currently set up to build each python library from source instead of using the wheel but this can be changed if preferable.
Possibly an issue is that the env is not automatically updated when new deps are added, it must be restarted.
Also the way pyright is working is a bad solution.

@PartyWumpus PartyWumpus marked this pull request as draft May 5, 2024 14:35
flake.nix Outdated Show resolved Hide resolved
Copy link
Member

@AAGaming00 AAGaming00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could probably add a .envrc too for direnv

@PartyWumpus PartyWumpus marked this pull request as ready for review May 7, 2024 14:52
@PartyWumpus PartyWumpus merged commit 97b62ac into aa/websockets May 12, 2024
9 checks passed
@PartyWumpus PartyWumpus deleted the websockets/flake.nix branch May 25, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants