-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] skip create rows mapper file when compaction output rowset is empty #45715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyb
previously approved these changes
May 16, 2024
decster
previously approved these changes
May 16, 2024
…set is empty Signed-off-by: luohaha <[email protected]>
Signed-off-by: luohaha <[email protected]>
luohaha
force-pushed
the
improve-light-compact
branch
from
May 16, 2024 07:27
8c623ca
to
a4de83c
Compare
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 2 / 2 (100.00%) file detail
|
wyb
approved these changes
May 16, 2024
decster
approved these changes
May 16, 2024
@Mergifyio backport branch-3.3 |
@Mergifyio backport branch-3.2 |
@Mergifyio backport branch-3.1 |
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
May 16, 2024
…set is empty (#45715) Signed-off-by: luohaha <[email protected]> (cherry picked from commit 9bbe82c)
42 tasks
mergify bot
pushed a commit
that referenced
this pull request
May 16, 2024
…set is empty (#45715) Signed-off-by: luohaha <[email protected]> (cherry picked from commit 9bbe82c)
mergify bot
pushed a commit
that referenced
this pull request
May 16, 2024
…set is empty (#45715) Signed-off-by: luohaha <[email protected]> (cherry picked from commit 9bbe82c)
wanpengfei-git
pushed a commit
that referenced
this pull request
May 16, 2024
…set is empty (backport #45715) (#45744) Co-authored-by: Yixin Luo <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
May 16, 2024
…set is empty (backport #45715) (#45746) Co-authored-by: Yixin Luo <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
May 16, 2024
…set is empty (backport #45715) (#45745) Co-authored-by: Yixin Luo <[email protected]>
node
pushed a commit
to vivo/starrocks
that referenced
this pull request
May 17, 2024
…set is empty (StarRocks#45715) Signed-off-by: luohaha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
After we support light pk compaction publish (#43934), we will create a
.crm
file when compaction finish, but it will still create.crm
file even when output rowset is empty, which is unnecessary.What I'm doing:
skip create rows mapper file when compaction output rowset is empty
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: