Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] skip create rows mapper file when compaction output rowset is empty #45715

Merged
merged 2 commits into from
May 16, 2024

Conversation

luohaha
Copy link
Contributor

@luohaha luohaha commented May 16, 2024

Why I'm doing:

After we support light pk compaction publish (#43934), we will create a .crm file when compaction finish, but it will still create .crm file even when output rowset is empty, which is unnecessary.

What I'm doing:

skip create rows mapper file when compaction output rowset is empty

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@luohaha luohaha requested a review from a team as a code owner May 16, 2024 03:24
wyb
wyb previously approved these changes May 16, 2024
decster
decster previously approved these changes May 16, 2024
@luohaha luohaha enabled auto-merge (squash) May 16, 2024 04:47
@luohaha luohaha dismissed stale reviews from decster and wyb via 8c623ca May 16, 2024 07:27
Copy link

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[BE Incremental Coverage Report]

pass : 2 / 2 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/storage/rows_mapper.cpp 2 2 100.00% []

@luohaha luohaha merged commit 9bbe82c into StarRocks:main May 16, 2024
43 checks passed
Copy link

@Mergifyio backport branch-3.3

Copy link

@Mergifyio backport branch-3.2

Copy link

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label May 16, 2024
Copy link
Contributor

mergify bot commented May 16, 2024

backport branch-3.3

✅ Backports have been created

Copy link
Contributor

mergify bot commented May 16, 2024

backport branch-3.2

✅ Backports have been created

Copy link
Contributor

mergify bot commented May 16, 2024

backport branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request May 16, 2024
…set is empty (#45715)

Signed-off-by: luohaha <[email protected]>
(cherry picked from commit 9bbe82c)
mergify bot pushed a commit that referenced this pull request May 16, 2024
…set is empty (#45715)

Signed-off-by: luohaha <[email protected]>
(cherry picked from commit 9bbe82c)
mergify bot pushed a commit that referenced this pull request May 16, 2024
…set is empty (#45715)

Signed-off-by: luohaha <[email protected]>
(cherry picked from commit 9bbe82c)
wanpengfei-git pushed a commit that referenced this pull request May 16, 2024
wanpengfei-git pushed a commit that referenced this pull request May 16, 2024
wanpengfei-git pushed a commit that referenced this pull request May 16, 2024
node pushed a commit to vivo/starrocks that referenced this pull request May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants