Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix Column Id cause BE crash when doing schema change #45691

Conversation

gengjun-git
Copy link
Contributor

Why I'm doing:

Should send the column name to BE if the column is shadow column

What I'm doing:

Fixes https://github.com/StarRocks/StarRocksTest/issues/7402

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

Signed-off-by: gengjun-git <[email protected]>
@gengjun-git gengjun-git requested review from a team as code owners May 15, 2024 14:14
Copy link

sonarcloud bot commented May 15, 2024

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 9 / 9 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/planner/OlapTableSink.java 4 4 100.00% []
🔵 com/starrocks/catalog/Column.java 1 1 100.00% []
🔵 com/starrocks/analysis/SlotDescriptor.java 4 4 100.00% []

@nshangyiming nshangyiming enabled auto-merge (squash) May 16, 2024 03:41
@nshangyiming nshangyiming merged commit ac0edfa into StarRocks:main May 16, 2024
50 checks passed
node pushed a commit to vivo/starrocks that referenced this pull request May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants