Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix https://github.com/Sprytile/Sprytile/issues/139 #140

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ajbaldocchi
Copy link

sel_min uses Blender's Vector which returns floats but tilegrid.tile_selection[#] expects int so an int is created when assigned in sprytile_gui.py

draw_preview can be used before modal in sprytile_modal.py so is initialized outside of modal()

@VictoriousFan
Copy link

Ay thanks for this fix

@ajbaldocchi ajbaldocchi mentioned this pull request Jul 3, 2022
@TheBricktop
Copy link

Ive tried Your fix too and im sorry to say that the scaling of the palette works but as soon as im starting to create new tiles in edit mode im greeted with long list of errors and the blender crashes, im using Your version on blender 3.2.2

@ajbaldocchi
Copy link
Author

@TheBricktop are you applying these changes on top of 0.5.25 or are you just checking out this version? These changes are based on master (which is 0.5.10) but master doesn't have the other open PR merged (but the 0.5.25 version you install from itch.io does have it included). To run successfully you need both sets of changes so the best option is to install 0.5.25 and then manually apply the changes from this PR to it.

@TheBricktop
Copy link

Since the original owner of sprytile is not active on GitHub I could merge the changes on my fork for brevity.

@ajbaldocchi
Copy link
Author

Considering the permissive MIT license you're welcome to do all of the modifications you would like on your fork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants