Fix t_starts not propagated to save_to_memory.
#3120
Conversation
JoeZiminski
changed the title
t_starts not propagated to save memory.t_starts not propagated to save_to_memory.
JoeZiminski
force-pushed
the
fix_save_to_memory_t_start
branch
from
4005c75
to
16d4089
Compare
There was a problem hiding this comment.
Let's move the corresponding tests from #3117 to here.
I suspect that you tested this in #3117 because you wanted to have a canonical way for seting the t_start in your tests but you don't really need it, t_start is a public attribute of the segment class.
Plus, you are adding interface in #3117 and the tests should not depend on the newly added interface. Having t_start as an attribute of the segment class is a deper contract that the interface at the recording class and the tests of the interface should rely on the machinery that is already baked in on the data model.
| @@ -545,11 +545,11 @@ def _save(self, format="binary", verbose: bool = False, **save_kwargs): | |||
| if kwargs.get("sharedmem", True): | |||
| from .numpyextractors import SharedMemoryRecording | |||
|
|
|||
| cached = SharedMemoryRecording.from_recording(self, **job_kwargs) | |||
| cached = SharedMemoryRecording.from_recording(self, t_starts=t_starts, **job_kwargs) | |||
There was a problem hiding this comment.
Cool. thanks a lot I forgot it.
| @@ -85,7 +85,7 @@ def __init__(self, traces_list, sampling_frequency, t_starts=None, channel_ids=N | |||
| } | |||
|
|
|||
| @staticmethod | |||
| def from_recording(source_recording, **job_kwargs): | |||
| def from_recording(source_recording, t_starts=None, **job_kwargs): | |||
There was a problem hiding this comment.
Not sure to agree with this. The t_tsarts should be taken from the source recording. No ?
There was a problem hiding this comment.
Mayybe we should make a private method for this
https://github.com/SpikeInterface/spikeinterface/pull/3120/files#diff-6b93c507ba0be7d51533ba5d6d6bb00e9b4481bd887646d4e436496164ba0ec8R503-R508
and use it at several places. No ?
| @@ -211,18 +212,16 @@ def __del__(self): | |||
| shm.unlink() | |||
|
|
|||
| @staticmethod | |||
| def from_recording(source_recording, **job_kwargs): | |||
| def from_recording(source_recording, t_starts=None, **job_kwargs): | |||
This PR closes #2515 by propagated
t_startsto memory recording objects duringsave_to_memory. This is tested in #3117.This works to propagate the times to save to memory, and tests are passing, but I havn't considered other uses for these recording classes. So it would be great if others could let me know if this might break anything elsewhere! I can't see why it would as it uses default kwargs that maintain the old behaviour, but still I'm paranoid 馃槄