Dredge lfp and dredge ap #3062
Draft
Dredge lfp and dredge ap #3062
+3,435
−1,840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alejoe91
reviewed
Jun 22, 2024
| @@ -49,6 +47,12 @@ def setup_module(tmp_path_factory): | |||
| return recording, sorting, cache_folder | |||
|
|
|||
|
|
|||
| @pytest.fixture(scope="module", name="setup_module") | |||
| def setup_module_fixture(tmp_path_factory): | |||
There was a problem hiding this comment.
You can use the create_cache_folder global fixture ;)
Move method into separated files. Change, refactor (and rename some) kwargs from common to specific methos. Add dredge_lfp class.
|
@cwindolf the last commit is a quite big refactoring in estimate motion to integrate the 'dredge_lfp' method. |
|
@cwindolf I could not resists in porting also the dredge_ap and make a class. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cwindolf
Here the initial port of dredgelib into spikeinterface.
This come with some small refactoring in spikeinterface and folder reorganization.
We should be able to do:
estimate_motion(method="drege_lfp")estimate_motion(method="drege_ap")The come a a quite big refactoring to split methods and into files and many variable names change to align with dredge in spikeinterface and sometimes the align dredge with spikeinterface.
The entire dredge is in one unique file dredge.py