Feature/cwall 199 #195
Open
Feature/cwall 199 #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nklomp
reviewed
May 8, 2024
BtencateSphereon
previously requested changes
May 10, 2024
nklomp
reviewed
May 23, 2024
packages/oid4vci-holder/__tests__/shared/oid4vciHolderLogicAgentLogic.ts
Outdated
Show resolved
Hide resolved
…) and run prettier
nklomp
requested changes
May 23, 2024
packages/oid4vci-holder/__tests__/shared/oid4vciHolderLogicAgentLogic.ts
Outdated
Show resolved
Hide resolved
…) and run prettier
…level library) and removed duplicated "Logic" from function name
nklomp
requested changes
Jun 5, 2024
| @@ -288,8 +288,7 @@ export type ErrorDetails = { | |||
| export enum RequestType { | |||
| OPENID_INITIATE_ISSUANCE = 'openid-initiate-issuance', | |||
| OPENID_CREDENTIAL_OFFER = 'openid-credential-offer', | |||
| HTTPS = 'https', | |||
| HTTP = 'http', | |||
| URL = 'http', | |||
There was a problem hiding this comment.
Why is the value still http though?
There was a problem hiding this comment.
Because I'm following the flow of the existing code which checks url/uri starts with a specific scheme. In this case if I use the key URL it will match both http and https.
There was a problem hiding this comment.
Don't like that at all, but will change it at a later point I guess.
packages/oid4vci-holder/__tests__/shared/oid4vciHolderLogicAgentLogic.ts
Outdated
Show resolved
Hide resolved
|
Please fix the lock file conflict |
nklomp
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.