Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/SDK-10 #184

Draft
wants to merge 30 commits into
base: develop
Choose a base branch
from
Draft

feature/SDK-10 #184

wants to merge 30 commits into from

Conversation

maikel-maas
Copy link
Contributor

No description provided.

@maikel-maas maikel-maas marked this pull request as ready for review April 23, 2024 16:21
@nklomp nklomp marked this pull request as draft April 23, 2024 16:54
nklomp
nklomp requested changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@nklomp nklomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need a significant amount of changes. Never ever require private keys in methods, except for the KMS no agent plugin can access private keys

packages/ebsi-authorization-client/src/agent/EBSIAuthorizationClient.ts Outdated Show resolved Hide resolved
packages/ebsi-authorization-client/src/agent/EBSIAuthorizationClient.ts Outdated Show resolved Hide resolved
packages/ebsi-authorization-client/src/agent/EBSIAuthorizationClient.ts Outdated Show resolved Hide resolved
packages/ebsi-authorization-client/src/agent/EBSIAuthorizationClient.ts Outdated Show resolved Hide resolved
packages/ebsi-authorization-client/src/agent/EBSIAuthorizationClient.ts Outdated Show resolved Hide resolved
packages/ebsi-authorization-client/src/agent/EBSIAuthorizationClient.ts Outdated Show resolved Hide resolved
packages/ebsi-authorization-client/src/types/IEBSIAuthorizationClient.ts Outdated Show resolved Hide resolved
packages/ebsi-authorization-client/src/types/IEBSIAuthorizationClient.ts Outdated Show resolved Hide resolved
packages/ebsi-authorization-client/src/types/IEBSIAuthorizationClient.ts Outdated Show resolved Hide resolved
packages/ebsi-authorization-client/src/types/IEBSIAuthorizationClient.ts Outdated
* @property {number} [exp] Expires at
* @property {string} [iss] Issuer (Authorisation API)
*/
export interface Ake1SigPayload {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this doing here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the response from the EBSI RP, at least part of it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed anymore

jcmelati
jcmelati reviewed Apr 26, 2024
View reviewed changes
packages/ebsi-authorization-client/src/agent/EBSIAuthorizationClient.ts Outdated
grant_type: 'vp_token',
vp_token: vpJwt,
presentation_submission: presentationSubmission,
scope: EBSIScope.didr_invite,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this scope come from args instead of being hardcoded?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retrieving the values from args now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcmelati jcmelati jcmelati left review comments

@nklomp nklomp nklomp requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maikel-maas @jcmelati @nklomp