Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid duplicated repos. #81

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

frankfliu
Copy link
Contributor

This fixes #80.

This might not be the best solution, it assumes DependencyResolver is an instanceof IBiblioResolver (this is not future proof).

@SpencerPark
Copy link
Owner

@frankfliu I like this, but maybe instead of looking for duplicate urls, we could skip duplicates based on the name.

A name should uniquely identify a resolver and that property is exposed on DependencyResolver. This ofc doesn't avoid the case where the same repo is added under multiple names but I don't think that is a case we should worry about. I believe that should however cover the common case outlined in #80. What do you think?

@frankfliu
Copy link
Contributor Author

I still have concern regarding name conflict. One of the use case is I opened multiple notebook, they are actually shared the same JVM, they actually can see each others resolver (I'm not sure if this is a bug). In this case, there are a high chance two notebook using the same common name like "s3" or "maven" for different URL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicated maven repo will be created if the same repo is executed multiple times
2 participants