Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify SolrDynamicField properties #548

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Modify SolrDynamicField properties #548

wants to merge 1 commit into from

Conversation

yokuno
Copy link

@yokuno yokuno commented Feb 15, 2021

Added properties such as type and indexed to solr dynamic field like a regular field.

@mausch
Copy link
Member

mausch commented Feb 18, 2021

Hi @yokuno , thanks for your PR!
I'll need you to fix a couple of things:
Please don't make formatting changes, or at least don't make them in the same commit where you're making the actual change. It makes it more difficult to review the change.
Also please add this change to SolrSchemaParserTests.

@yokuno
Copy link
Author

yokuno commented Feb 19, 2021

OK. I'll do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants