added support subdocument in SolrDictionarySerializer #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjunge
requested changes
Aug 17, 2017
There was a problem hiding this comment.
Can you rebase from the develop branch, and create a new PR to this develop branch?
The last week we've made major changes which break this PR:
- Use of xUnit instead of MBUnit (In general: change
[Test]to[ Fact], and remove the verb in theAssert(Assert.AreEqual=>Assert.Equal)
|
I would also like to see some more unit tests, making sure this change doesn't change the behavior off MultiValued fields (serializing multi valued fields to sub docs by mistake) |
mausch
force-pushed
the
master
branch
7 times, most recently
from
feb4635
to
135e296
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added support nesteed document in SolrDictionarySerializer