Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

44 add adjusted forecast scenario page #46

Merged
merged 19 commits into from
Jun 26, 2024

Conversation

amynickolls
Copy link
Contributor

Big one:

Adjusted forecast page added:

  • Chart shows forecast post adjustment
  • Accordion allows user to cycle through different rates, allow users to select which to edit

Rate adjustment pages (entry, exit and transition)

  • Use dynamic form to save adjustments to the session scenario
  • Displays a comparison chart showing base and adjusted forecast once saved
  • Offers navigation back to adjusted rate page or option to clear rate adjustments

Clear adjustments button clears all adjustments via clear_adjusted_rates view

Navigate to adjusted page via Start Modelling > Scroll to bottom > Next

@amynickolls amynickolls requested a review from tab1tha June 18, 2024 15:16
@amynickolls amynickolls linked an issue Jun 18, 2024 that may be closed by this pull request
@tab1tha
Copy link
Member

tab1tha commented Jun 21, 2024

Hi Amy,
Going through.

When I run this branch locally, I haven't succeeded arrive at the adjusted forecast view yet. This is my workflow:

  • it takes me to the start modelling page. The filters and graphs all work here. However,
  • When I click on the next button in the modeling page, this error shows up. It's possible that I am not running it correctly too...
image

@amynickolls
Copy link
Contributor Author

Hi Amy, Going through.
...

This is strange - I can't recreate it. Prediction.entry_rates was added in this PR though and the error was coming from a print statement left in there which I've now deleted so perhaps try updating the branch and see what happens?

@tab1tha
Copy link
Member

tab1tha commented Jun 21, 2024

Hi Amy, Going through.
...

This is strange - I can't recreate it. Prediction.entry_rates was added in this PR though and the error was coming from a print statement left in there which I've now deleted so perhaps try updating the branch and see what happens?

retrying....

Copy link
Member

@tab1tha tab1tha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran this code locally and the views and flows work.

Side note: All the other pages are on the top bar menu but this page requires that the user first clicks on the start modelling page (as said in the pr description). Is it possible to put it on the top menu too?
Clicking into a new page and not seeing the switch in the top menu was surprising but it's okay if that was an intentional design decision.

All good.

@amynickolls amynickolls merged commit 03d1699 into main Jun 26, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add adjusted forecast scenario page
2 participants