Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language Support #32

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Language Support #32

wants to merge 15 commits into from

Conversation

lilyrae
Copy link

@lilyrae lilyrae commented Nov 25, 2017

Hello!

I really like your project and wanted to be able to translate it to different languages. For now I've only worked on the text that gets printed out, not what is spoken or what the user says. That will be the next step!

I have done the following:

  • imported gettext to aid translation
  • added language to the config file
  • moved all strings into a translation file (/locales/en/LC_MESSAGES/messages.po)
    -> strings can now be translated by using _("msgid.found.in.translation.file")
  • made string formatting consistent (so always using "string {0}".format(variable) instead of other methods)
  • small styling changes

In the PR, you can see the messages.po files - these are the human readable translation files. To create the machine readable translation files (so that it actually works), you need to run the following command:
msgfmt messages.po -o messages.mo

Let me know what you think of the changes!

Also, I saw your comment about joining slack too late, and now the invitation link doesn't work. I work really like to join and discuss more about your project! 馃榿

@Nesh108
Copy link
Contributor

Nesh108 commented Nov 28, 2017

Heya @lilyrae, good stuff! I haven't had the chance to test it on my side but the changes seemed well done!

I can help out with the Italian translation if needed. We could look into some TTS engine for Italian.
@SlapBot, do you reckon the current one can support different languages?

@SlapBot
Copy link
Owner

SlapBot commented Nov 28, 2017

Hi there @lilyrae , Changes look absolutely amazing with how you abstracted the hard coded strings to a given file. This would make my job a whole lot easier especially on integrating the chat based engine. Unfortunately I couldn't find enough time to test it out, but I will get it done by this week and merge it with the master positively.

And @Nesh108 Yes definitely, The algorithm which parses the intent is language agnostic, but I haven't tried it with other languages yet, so it would be exciting to see what results we will get, I am happy to help in any way possible.

And both of you can join the slack group at: Stephanie-VA, so that we can work together more effectively and be able to solve other people queries too!

And again thanks for all kind of contributions. 馃槃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants