GPT4 integration #324
Merged
GPT4 integration #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i think it outlines a plan to evaluate the feasibility and cost-effectiveness of integrating the new GPT-4o model. The goal is to potentially reduce user costs by leveraging GPT-4o's purportedly lower pricing compared to GPT-4V.
suchintan
reviewed
May 15, 2024
suchintan
reviewed
May 15, 2024
suchintan
reviewed
May 15, 2024
skyvern/config.py
Outdated
| @@ -71,6 +71,7 @@ class Settings(BaseSettings): | |||
| ENABLE_ANTHROPIC: bool = False | |||
| ENABLE_AZURE: bool = False | |||
| ENABLE_BEDROCK: bool = False | |||
| ENABLE_GPT_4O: bool = False | |||
There was a problem hiding this comment.
You don't need these changes! The change is easier than you think :)
There was a problem hiding this comment.
Ahh, i get it. Thanks for the feedback, tho. :)
There was a problem hiding this comment.
@Ghastly2001 are you open to updating the PR? I'd love to get this merged:)
|
LFG!! |
Updated
suchintan
reviewed
May 16, 2024
| @@ -43,6 +46,17 @@ def get_config(cls, llm_key: str) -> LLMRouterConfig | LLMConfig: | |||
| return cls._configs[llm_key] | |||
|
|
|||
|
|
|||
| # Check if GPT-4o is enabled and register it | |||
| if SettingsManager.get_settings().ENABLE_GPT_4O: | |||
There was a problem hiding this comment.
I think you can delete this entire block
suchintan
reviewed
May 16, 2024
suchintan
reviewed
May 16, 2024
suchintan
reviewed
May 16, 2024
Removed unnecessary code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i think it outlines a plan to evaluate the feasibility and cost-effectiveness of integrating the new GPT-4o model. The goal is to potentially reduce user costs by leveraging GPT-4o's purportedly lower pricing compared to GPT-4V.