Refined Event On Command and Condition CondIsSkriptCommand
#6709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moderocky
requested changes
May 19, 2024
| public class CondIsValidCommand extends PropertyCondition<String> { | ||
|
|
||
| static { | ||
| register(CondIsValidCommand.class, PropertyType.BE, "[a[n]] [[:in]valid] [skript:s(k|c)ript] (command|cmd)", "strings"); |
There was a problem hiding this comment.
It may have been better to keep the old syntax and just made a new one for validity, or to have done separate patterns here
The combinatorial doesn't really make sense (is an invalid skript command different from an invalid command ?) and I don't think you gain much benefit from doing both together.
There was a problem hiding this comment.
I added the new invalid tag to have the users checking whether the provided command is valid, and I thought of fitting it for skript too to have users to check whether this skripted command is registered
sovdeeth
added
the
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refines the Skript event
on commandto allow specifying command executor in event.The
CondIsSkriptCommandis also refined toCondIsValidCommandto support plugin commands.Target Minecraft Versions: any
Requirements: none
Related Issues: none