Condition Slot has Space for Item #6677
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moderocky
approved these changes
May 9, 2024
sovdeeth
requested changes
Jun 10, 2024
Comment on lines
52
to
+55
| "%inventories% (can hold|ha(s|ve) [enough] space (for|to hold)) %itemtypes%", | ||
| "%inventories% (can(no|')t hold|(ha(s|ve) not|ha(s|ve)n't|do[es]n't have) [enough] space (for|to hold)) %itemtypes%"); | ||
| "%inventories% (can(no|')t hold|(ha(s|ve) not|ha(s|ve)n't|do[es]n't have) [enough] space (for|to hold)) %itemtypes%", | ||
| "%slots% (can hold|ha(s|ve) [enough] space (for|to hold)) %itemtype%", | ||
| "%slots% (can(no|')t hold|(ha(s|ve) not|ha(s|ve)n't|do[es]n't have) [enough] space (for|to hold)) %itemtype%"); |
There was a problem hiding this comment.
why are the patterns duplicated? just use %slots/inventories%
| return true; | ||
| } | ||
|
|
||
| @Override | ||
| public boolean check(Event e) { | ||
| return invis.check(e, | ||
| public boolean check(Event event) { |
There was a problem hiding this comment.
the slot and inventory logic could be separated into helper methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a condition to check for whether a slot has space for an item.
Tests dedicated to CondCanHold.java is also added.
Target Minecraft Versions: any
Requirements: none
Related Issues: #6256