Fix #479 Content Scripts not reloading bug #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @rushilsrivastava @vialoh could you review this when you have the time please? |
Hey @lucasrmendonca! Thanks for the pull requests. It's hard to say when exactly we'll be able to get around to this. Maybe in a couple of weeks, as we're focused on other things right now. Sorry for the delay! |
Before, when calling the plugin with the "manifest" option, the Content Scripts were not auto-reloading like they were when listing each entry as a separate argument. Now, using the "manifest" option also reloads the content scripts.
lucasrmendonca
force-pushed
the
fixContentScriptsWithManifest
branch
from
e5b3274
to
68a0f11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, when calling the plugin with the "manifest" option, the Content Scripts were not auto-reloading like they were when listing each entry as a separate argument.
Now, using the "manifest" option also reloads the content scripts.
Checklist
Closes #479