Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Content Script not reloading when using "manifest" argument for plugin #479

Open
1 of 2 tasks
lucasrmendonca opened this issue Feb 15, 2024 · 0 comments · May be fixed by #480
Open
1 of 2 tasks

Content Script not reloading when using "manifest" argument for plugin #479

lucasrmendonca opened this issue Feb 15, 2024 · 0 comments · May be fixed by #480
Assignees
@rushilsrivastava
Labels
type: bug A bug.

Comments

@lucasrmendonca
Copy link

Describe the bug

When calling the plugin with the "manifest" option, the Content Scripts are not auto-reloading:

new ExtensionReloader({
    entries: { manifest: path.resolve(process.cwd(), 'src/manifest.json') },
})

When calling it with the "entries", though, the Content Scripts reload.

Expected behavior

Content scripts should automatically reload when passing the manifest path just like when listing the entries object.

Environment:

  • OS: Ubuntu 20.04.6 LTS
  • Browser Version: Google Chrome Version 121.0.6167.184 (Official Build) (64-bit)
  • webpack Version: 5.89.0
  • webpack-ext-reloader Version: 1.1.12

I'm going to open a PR

  • yes
  • no
@lucasrmendonca lucasrmendonca added the type: bug A bug. label Feb 15, 2024
lucasrmendonca pushed a commit to lucasrmendonca/webpack-ext-reloader that referenced this issue Feb 15, 2024
Fix SimplifyJobs#479 Content Scripts not reloading bug
44dc023 
Before, when calling the plugin with the "manifest" option, the Content
Scripts were not auto-reloading like they were when listing each entry
as a separate argument.

Now, using the "manifest" option also reloads the content scripts.
@lucasrmendonca lucasrmendonca linked a pull request Feb 15, 2024 that will close this issue
Open
2 tasks
lucasrmendonca pushed a commit to lucasrmendonca/webpack-ext-reloader that referenced this issue Mar 29, 2024
@lucasrmendonca
Fix SimplifyJobs#479 Content Scripts not reloading bug
68a0f11 
Before, when calling the plugin with the "manifest" option, the Content
Scripts were not auto-reloading like they were when listing each entry
as a separate argument.

Now, using the "manifest" option also reloads the content scripts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rushilsrivastava rushilsrivastava

Labels
type: bug A bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #479 Content Scripts not reloading bug lucasrmendonca/webpack-ext-reloader
2 participants
@lucasrmendonca @rushilsrivastava