Change likes to reactions... #8187
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oldiesmann
changed the title
|
Also cc @Sesquipedalian since this will require changes to the DB schema stuff in #8093 |
|
Good job. IMO this also should be done for 2.1 |
|
2.1 is feature frozen and receives bug fixes only.
…On Sun, May 5, 2024 at 9:52 PM asmith20002 ***@***.***> wrote:
Good job. IMO this also should be done for 2.1
—
Reply to this email directly, view it on GitHub
<#8187 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADJNN5J44LLS3XBZI3OVHLZA4EAPAVCNFSM6AAAAABG3Y3IX6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJVGE4TIOJXGA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
latest upstream changes
Signed-off-by: Michael Eshom <[email protected]>
…pdates/deletions/additions
…r the list. More to come...
- Add code to handle separate buttons for deleting/saving - Add placeholders for additional row and inline JS - Add closing PHP tag for consistency
- Update the get_items function per specs - Move the do_update conditional to the proper spot - Add the buttons and a checkbox column for deleting stuff
- Add javascript for adding said new row
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes SMF's likes feature into a full-fledged reactions system.
Features:
Admins can add/remove reactions as desired (only limit is defined by the limits of the SMALLINT data type, which should be plenty)
For simplicity, it will use images in a reactions folder in the theme's images folder and will look for a $txt['react_{name}'] string for i18n (defaults to 'name' defined in the database if not found)
Work done so far:
Still to do:
Note that the upgrade uses a combination of db API functions and upgrade_query. In some situations (such as creating a table), upgrade_query is far simpler than the associated db API call.