Update elastix to April 19 2024 hash

[blowekamp]

No description provided.

[blowekamp]

@N-Dekker Even after this update I am seeming a large number of warning from Elastix. A lot of "unused typedefs", "overloaded virtual", "unused parameter" etc. Is this expected or does something need to be corrected with the build?

[N-Dekker]

A lot of "unused typedefs", "overloaded virtual", "unused parameter" etc. Is this expected or does something need to be corrected with the build?

Thanks for reporting, but I don't know! Maybe you use a different compiler version, or a different warning level. Can you give me the list of warnings with details? Are they at https://open.cdash.org/index.php?project=SimpleITK ?

[blowekamp]

I saw those locally with Apple clang 14.0.0. I don't believe the extra warning flag enable for SimpelITK are passed to the Elastix build.

The CI for this PR failed with a missing header:
I saw those local. But the CI for this PR failed with a missing header:
https://open.cdash.org/viewBuildError.php?buildid=9567908

"Elastix-prefix/include/Core/ComponentBaseClasses/elxFixedImagePyramidBase.h:26:10: fatal error: itkMultiResolutionPyramidImageFilter.h: No such file or directory"

[N-Dekker]

The CI for this PR failed with a missing header: I saw those local. But the CI for this PR failed with a missing header: https://open.cdash.org/viewBuildError.php?buildid=9567908

"Elastix-prefix/include/Core/ComponentBaseClasses/elxFixedImagePyramidBase.h:26:10: fatal error: itkMultiResolutionPyramidImageFilter.h: No such file or directory"

itkMultiResolutionPyramidImageFilter.h is here: https://github.com/InsightSoftwareConsortium/ITK/blob/master/Modules/Registration/Common/include/itkMultiResolutionPyramidImageFilter.h

So I think the compiler command-line for "Code/ElastixTransformixWrappers/src/sitkElastixImageFilterImpl.cxx" at https://open.cdash.org/viewBuildError.php?buildid=9567908 should have something like:

 -I/.../SimpleITK-build/ITK/Modules/Registration/Common/include

But I don't see it 🤷 Is it missing somehow?

[blowekamp]

@N-Dekker I think the Elastix libraries did not express their build dependencies in a conventional way to they were explicitly add here: https://github.com/SimpleITK/SimpleITK/blob/master/Code/ElastixTransformixWrappers/src/CMakeLists.txt#L8 I am testing adding ITKRegistrationCommon now.

P.S. Additionally the warning are produced when using the Elastix libraries in SimpleITK with those additional warning flags enabled.

[N-Dekker]

@blowekamp I just tried to upgrade the elastix CI from macos-12 to macos-14: https://github.com/SuperElastix/elastix/tree/GitHubActions-macos-14

Unfortunately, it did not give me the warnings you mentioned at #2104 (comment) Instead, I just got:

ld: warning: ignoring duplicate libraries: '-lm', '/.../ITK-build/lib/libITKCommon-5.4.a', ...

at https://my.cdash.org/viewBuildError.php?type=1&buildid=2549153

Do you have a suggestion how I can get "your" elastix warnings, instead?

[blowekamp]

The warnings are related to these flags:

-Wunused-parameter
-Wshadow
-Wdeprecated-declarations
-Woverloaded-virtual

Which I believe are being automatically added by: https://github.com/SimpleITK/SimpleITK/blob/7257d455d19bef2c13f696fbc2a4dc950685aacb/CMake/sitkCompilerWarningsSettings.cmake

[N-Dekker]

@blowekamp FYI, I'm preparing a PR to fix those warnings that you encountered: SuperElastix/elastix@main...Enable--Wshadow-Woverloaded-virtual

Wow, disappointing: I thought I fixed all 50 warnings from https://my.cdash.org/viewBuildError.php?type=1&buildid=2549592 but after pushing the fixes, it just produces 50 other warnings. Apparently it only shows 50 warnings at a time.

---

Ah, I see, at the elastix dashboard page https://my.cdash.org/viewBuildError.php?type=1&buildid=2549649

The maximum number of reported warnings or errors has been reached!!!

Update: I just found how to increase the maximum number of reported warnings, at

SimpleITK/CMake/CTestCustom.cmake.in

Line 2 in 2ba0e6f

SET (CTEST_CUSTOM_MAXIMUM_NUMBER_OF_WARNINGS 999)

😃

[blowekamp]

There are some now showing in the CI dashboard for this PR here: https://open.cdash.org/viewBuildError.php?type=1&buildid=9570768

[N-Dekker]

@blowekamp I'm sorry to say the extra compiler flags (-Wunused-parameter -Wshadow -Wdeprecated-declarations -Woverloaded-virtual) produce more warnings than I expected. For -Wshadow alone, it's already 1000+: https://my.cdash.org/viewBuildError.php?type=1&buildid=2550567 So it takes me more time than expected 🤷 To be continued...

[blowekamp]

@blowekamp I'm sorry to say the extra compiler flags (-Wunused-parameter -Wshadow -Wdeprecated-declarations -Woverloaded-virtual) produce more warnings than I expected. For -Wshadow alone, it's already 1000+: https://my.cdash.org/viewBuildError.php?type=1&buildid=2550567 So it takes me more time than expected 🤷 To be continued...

Thank you for working on this. Hopefully, you can find some tools to automate some of the cleanup.

[N-Dekker]

@blowekamp It took a while, but I think I addressed all of those (2000+) warnings, with elastix pull request SuperElastix/elastix#1136 commit SuperElastix/elastix@78fe482, now at the main branch of https://github.com/SuperElastix/elastix Thanks for your patience 😃 Can you please give it another try?