Added sentry error logging #6867
Open
+38
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for auto-gpt-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Pwuts
requested changes
Mar 15, 2024
There was a problem hiding this comment.
Please rebase this on the Sentry integration we already have: https://github.com/Significant-Gravitas/AutoGPT/blob/master/autogpts/autogpt/autogpt/app/telemetry.py
And please run the linters to fix any formatting issues before pushing.
| @@ -184,7 +190,7 @@ def configure_logging( | |||
| json_logger.propagate = False | |||
|
|
|||
| # Disable debug logging from OpenAI library | |||
| openai_logger.setLevel(logging.WARNING) | |||
| openai_logger.setLevel(logging.INFO) | |||
There was a problem hiding this comment.
Why? We don't want all of OpenAI's internal logging to show up in the application log, because it's quite a lot.
Comment on lines
+82
to
+87
| level: int = logging.INFO, | ||
| log_dir: Path = LOG_DIR, | ||
| log_format: Optional[LogFormatName] = None, | ||
| log_file_format: Optional[LogFormatName] = None, | ||
| plain_console_output: bool = False, | ||
| tts_config: Optional[TTSConfig] = None, |
Comment on lines
+24
to
+26
| import sentry_sdk | ||
| from sentry_sdk.integrations.logging import LoggingIntegration | ||
|
|
There was a problem hiding this comment.
improper placement of 3rd party imports
| @@ -9,7 +9,7 @@ | |||
| from typing import TYPE_CHECKING, Optional | |||
|
|
|||
| from auto_gpt_plugin_template import AutoGPTPluginTemplate | |||
| from openai._base_client import log as openai_logger | |||
| from openai.util import logger as openai_logger | |||
|
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
github-actions
bot
added
the
conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Changes 🏗️
PR Quality Scorecard ✨
+2 pts+5 pts+5 pts+5 pts-4 pts+4 pts+5 pts-5 ptsagbenchmarkto verify that these changes do not regress performance?+10 pts