Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RevenueRetrieval2 stats approximation tolerance #5945

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

namesty
Copy link

@namesty namesty commented Oct 25, 2023

Background

Just like with #5782 issue with 2013's revenue, not all sources report the numbers with the decimal precision expected by the benchmark string matchers, for all years. Some sources like: https://www.macrotrends.net/stocks/charts/TSLA/tesla/revenue and https://www.statista.com/statistics/272120/revenue-of-tesla/ report the results with the approximation that the current benchmarks expect. But several others don't:

2008 | $15 million
2009 | $112 million
2010 | $117 million
2011 | $204 million
2012 | $413 million
2013 | $2.01 billion
2014 | $3.2 billion
2015 | $4.05 billion
2016 | $7 billion
2017 | $11.76 billion
2018 | $21.46 billion
2019 | $24.58 billion
2020 | $31.54 billion
2021 (Q1+Q2) | $22.35 billion
2009 | $111.9M
2010 | $116.7M
2011 | $204.2M
2012 | $413.3M
2013 | $2.0B
2014 | $3.2B
2015 | $4.0B
2016 | $7.0B
2017 | $11.8B
2018 | $21.5B
2019 | $24.6B
2020 | $31.5B
2021 | $53.8B
2022 | $81.5B
2023 (TTM) | $94.02 B
2022 | $81.46 B
2021 | $53.82 B
2020 | $31.53 B
2019 | $24.57 B
2018 | $21.46 B
2017 | $11.75 B
2016 | $7.00 B
2015 | $4.04 B
2014 | $3.19 B
2013 | $2.01 B
2012 | $0.41 B
2011 | $0.20 B
2010 | $0.11 B
2009 | $0.11 B
Dec 31, 2022 | 81.46B
Dec 31, 2021 | 53.82B
Dec 31, 2020 | 31.54B
Dec 31, 2019 | 24.58B
Dec 31, 2018 | 21.46B
Dec 31, 2017 | 11.76B
Dec 31, 2016 | 7.00B
Dec 31, 2015 | 4.05B
Dec 31, 2014 | 3.20B
Dec 31, 2013 | 2.01B
Dec 31, 2012 | 413.26M
Dec 31, 2011 | 204.24M
Dec 31, 2010 | 116.74M
Dec 31, 2009 | 111.94M
Dec 31, 2008 | 14.74M

Therefore, I think the benchmarks should account for these approximation variances; as this is expected from internet statistics. This has already been done with #5782 's 2013 approximation.

Changes πŸ—οΈ

  • Make statistic string matchers for tesla's annual revenue more tolerant to approximation variances

PR Quality Scorecard ✨

  • Have you used the PR description template?   +2 pts
  • Is your pull request atomic, focusing on a single change?   +5 pts
  • [] Have you linked the GitHub issue(s) that this PR addresses?   +5 pts
  • Have you documented your changes clearly and comprehensively?   +5 pts
  • Have you changed or added a feature?   -4 pts
    • Have you added/updated corresponding documentation?   +4 pts
    • Have you added/updated corresponding integration tests?   +5 pts
  • Have you changed the behavior of AutoGPT?   -5 pts
    • Have you also run agbenchmark to verify that these changes do not regress performance?   +10 pts

@namesty namesty requested a review from a team October 25, 2023 16:30
@netlify
Copy link

netlify bot commented Oct 25, 2023

βœ… Deploy Preview for auto-gpt-docs ready!

Name Link
πŸ”¨ Latest commit a3df70b
πŸ” Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/6539429b1c2a620008261709
😎 Deploy Preview https://deploy-preview-5945--auto-gpt-docs.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Jan 2, 2024
Copy link

github-actions bot commented Jan 2, 2024

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conflicts Automatically applied to PRs with merge conflicts size/m
Projects
Status: πŸ†• Needs initial review
Development

Successfully merging this pull request may close these issues.

None yet

1 participant