RevenueRetrieval2 stats approximation tolerance #5945
+6
β6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Just like with #5782 issue with 2013's revenue, not all sources report the numbers with the decimal precision expected by the benchmark string matchers, for all years. Some sources like: https://www.macrotrends.net/stocks/charts/TSLA/tesla/revenue and https://www.statista.com/statistics/272120/revenue-of-tesla/ report the results with the approximation that the current benchmarks expect. But several others don't:
Therefore, I think the benchmarks should account for these approximation variances; as this is expected from internet statistics. This has already been done with #5782 's 2013 approximation.
Changes ποΈ
PR Quality Scorecard β¨
+2 pts
+5 pts
+5 pts
+5 pts
-4 pts
+4 pts
+5 pts
-5 pts
agbenchmark
to verify that these changes do not regress performance? β+10 pts