feat: show error message received from the server in logs explorer views #4898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
YounixM
commented
Apr 22, 2024
YounixM
commented
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
nityanandagohain
approved these changes
Apr 23, 2024
palashgdev
reviewed
Apr 23, 2024
|
|
||
| export default function LogsError({ | ||
| errorData, | ||
| }: { |
There was a problem hiding this comment.
ideally we should avoid using inline defining of interface
palashgdev
reviewed
Apr 23, 2024
| let serverErrorMessage = null; | ||
|
|
||
| if (errorData && errorData.cause) { | ||
| serverErrorMessage = (errorData.cause as QueryRangeErrorCauseType).error; |
There was a problem hiding this comment.
there should not be any type of assertion bad practice
ideally, this should be handled from central place
There was a problem hiding this comment.
Error type has a standard type in case of New Error() and the cause property type is set to unknown and we are setting cause to be an object with the error property. Hence this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.