Update eslint plugin versions #420
Merged
+1,115
−711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BPScott
force-pushed
the
eslintbump
branch
2 times, most recently
from
f481403
to
e1c7a84
Compare
|
Uugh, I'm gonna need somebody with adminship to remove "Test (16.x)" as a required commit, as eslint will now no longer run on node 16 (which has been EOL for the last 6 months anyway). |
|
/snapit |
|
/snapit |
|
🫰✨ Thanks @BPScott! Your snapshot has been published to npm. Test the snapshot by updating your "@shopify/eslint-plugin": "0.0.0-snapshot-20240517012000" |
|
Working pretty well over here: https://github.com/Shopify/checkout-web/pull/34071 Main gotcha is that |
Major updates: - Update required node version to `18.20.0` - Update required eslint version to `^8.56.0` - Update `@typescript-eslint/eslint-plugin` to `^7.9.0` - Update `eslint-plugin-jest` to `^28.5.0` - Update `eslint-config-prettier` to `^9.1.0`
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major updates:
18.20.0^8.56.0@typescript-eslint/eslint-pluginto^7.9.0eslint-plugin-jestto^28.5.0eslint-config-prettierto^9.1.0The node and eslint version bumps are a result of updating
@typescript-eslint/eslint-pluginto v7.Most notably, updating
@typescript-eslint/eslint-pluginfixes theWARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.warnings when using Typescript 5.4.0 and above