Skip to content
This repository has been archived by the owner on Oct 20, 2023. It is now read-only.

Add custom selectors option. Fix theme-product-form logic #148

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

savchukoleksii
Copy link

Purpose

The goal of this PR is to add an optional parameter to pass custom selectors to theme-product-form. Currenly, it is always default to fixed selector. This would open allow fix apps issues that happen during same selectors in form. For example, ReCharge that currently broke this lib.
This problems also mentioned in issues:
#135
#146

Also id change logic was changed. Many apps depens on id field during initializing as also many of them depens on change event of this field. Logic was rebuild to always change id field, so apps logic will not be corrupt.

Approach

  • Add option to pass custom selectors to lib.
  • Fix theme-product-form logic for apps like ReCharge.

@savchukoleksii
Copy link
Author

@NoZiL @martinamarien
Please, review this changes

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant