slate-tools ships with Eslint 4 but references Eslint 5 definitions #800

[tanhengyeow]

What are you trying to accomplish with this PR?

Fixes #800.

[t-kelly]

@tanhengyeow can you please confirm you tested this? I'm a little worried that other dependencies in both Slate and Starter Theme will not play well with EsLint 5.

[tanhengyeow]

Hi @t-kelly

I ran yarn upgrade and these are the only warnings I got related to eslint:

warning " > [email protected]" has incorrect peer dependency "eslint@<5 >=4.7.1".
warning "eslint-plugin-shopify > [email protected]" has incorrect peer dependency "eslint@^2.0.0 || ^3.0.0 || ^4.0.0".

Running yarn test afterwards passed all 19 test suites.

Feel free to tell me if I missed out anything or something you would like me to try to ensure we don't regress here 😄

[tanhengyeow]

Hi @t-kelly

Gentle reminder to review this :)

[t-kelly]

Running yarn test afterwards passed all 19 test suites.

We don't have 100% test coverage so you will need to manually run all Slate commands and make sure you didn't break anything.