Allow declarative webhooks template #4043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! Depending on what you are working on, you may want to request a review from a Shopify team:
|
Coverage report
Show files with reduced coverage 🔻
Test suite run success1694 tests passing in 792 suites. Report generated by 🧪jest coverage report action from c65fcca |
|
We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset. |
alexanderMontague
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Related to https://github.com/Shopify/develop-app-inner-loop/issues/1504
We are adding declarative webhooks to the templates in Shopify/shopify-app-template-remix#743 and Shopify/shopify-app-template-ruby#131, but it's failing because not a valid schema in the CLI.
WHAT is this pull request doing?
The templates include a very simple legacy app schema, and then the CLI transforms it to the new schema when linking. But the legacy schema doesn't support webhooks, so I'm adding it here to be able to load the app.
How to test your changes?
p shopify app init --template=https://github.com/Shopify/shopify-app-template-remix#declarative-webhooksp shopify app init --template=https://github.com/Shopify/shopify-app-template-ruby#declarative-webhooksMeasuring impact
How do we know this change was effective? Please choose one:
Checklist
devordeployhave been reflected in the internal flowchart.