Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Shopify/theme-tools packages #4017

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Conversation

karreiro
Copy link
Contributor

@karreiro karreiro commented Jun 10, 2024

In this PR

  • Bump Shopify/theme-tools packages
  • Add VariableName check
  • Update Theme Check parser

How to test your changes?

  • dev clone dawn
  • pnpm shopify theme check --path ../dawn should pickup the .theme-check.yml file and check dawn

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

@karreiro karreiro requested a review from lucyxiang June 10, 2024 09:23
Copy link
Contributor

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/app-management

Copy link
Contributor

github-actions bot commented Jun 10, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
72.46% (-0.01% 🔻)
7392/10201
🟡 Branches
69.11% (-0.02% 🔻)
3635/5260
🟡 Functions 71.58% 1962/2741
🟡 Lines
72.8% (-0.01% 🔻)
6978/9585
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / ConcurrentOutput.tsx
98.39% (-1.61% 🔻)
90.91% (-4.55% 🔻)
100%
98.33% (-1.67% 🔻)

Test suite run success

1704 tests passing in 794 suites.

Report generated by 🧪jest coverage report action from 2a6341b

@karreiro karreiro requested review from isaacroldan and lucyxiang and removed request for lucyxiang June 11, 2024 11:31
@karreiro karreiro force-pushed the bump/theme-tools-2024-06-10 branch from 0360fe0 to 2a6341b Compare June 18, 2024 12:24
@karreiro karreiro added this pull request to the merge queue Jun 18, 2024
Merged via the queue into main with commit 923ccd2 Jun 18, 2024
35 checks passed
@karreiro karreiro deleted the bump/theme-tools-2024-06-10 branch June 18, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants