Fixed annotating gitlab merge request when using only depscan. #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prabhu
approved these changes
Mar 16, 2022
|
@adarshshetty1 Thank you for this PR! Did you get a chance to test this? Could you share any screenshot or public repo since I don't have time to test this personally? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using depscan with other tools creates a comment on merge request on gitlab. But using only depscan module does not create the comment on merge request on gitlab as depscan has no finding file/ sarif files & hence it passes through should_annotate function. I've tried to fix this issue which is also mentioned in #357