This repository has been archived by the owner on May 9, 2023. It is now read-only.
release_v3.0 #460
Open
release_v3.0 #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ath (#448) As discussed in #446 it can be valuable to add an commandline option to generate the default config file is this was somehow eliminated by setup. --generate-config-file flag option was added. Sample run will be something like this: autoxtrabackup --generate-config-file --verbose 2021-10-03 19:03:07 INFO [autoxtrabackup:278] Default config file is generated in /home/shako/.autoxtrabackup/autoxtrabackup.cnf 2021-10-03 19:03:07 INFO [autoxtrabackup:313] Xtrabackup command history: 2021-10-03 19:03:07 INFO [autoxtrabackup:315] ['command', 'xtrabackup_function', 'start time', 'end time', 'duration', 'exit code'] 2021-10-03 19:03:07 INFO [autoxtrabackup:316] Autoxtrabackup completed successfully!
The wrong config option was used and it fails when the tool tries to use backup archive feature. Now it will raise BackupArchiveNotConfigured error if options were not set and also it will check for archive_max_duration
Sourcery Code Quality Report✅ Merging this PR will increase code quality in the affected files by 11.39%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The major code refactorings and project restructuring.