Skip to content
This repository has been archived by the owner on May 9, 2023. It is now read-only.

Major refactorings - iteration 1 (Sourcery refactored) #459

Open
wants to merge 1 commit into
base: v3.0
Choose a base branch
from

Conversation

sourcery-ai[bot]
Copy link
Contributor

@sourcery-ai sourcery-ai bot commented Apr 9, 2022

Pull Request #458 refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the v3.0 branch, then run:

git fetch origin sourcery/v3.0
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

@sourcery-ai sourcery-ai bot requested a review from ShahriyarR April 9, 2022 14:35
@sourcery-ai sourcery-ai bot force-pushed the sourcery/v3.0 branch 17 times, most recently from bf424b1 to a30ec1d Compare April 13, 2022 09:51
@sourcery-ai
Copy link
Contributor Author

sourcery-ai bot commented Apr 13, 2022

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.46%.

Quality metrics Before After Change
Complexity 0.65 ⭐ 0.63 ⭐ -0.02 👍
Method Length 57.00 ⭐ 56.17 ⭐ -0.83 👍
Working memory 6.22 🙂 6.00 ⭐ -0.22 👍
Quality 80.03% 80.49% 0.46% 👍
Other metrics Before After Change
Lines 243 240 -3
Changed files Quality Before Quality After Quality Change
docs/conf.py 73.00% 🙂 78.28% ⭐ 5.28% 👍
mysql_autoxtrabackup/api/controller/controller.py 85.77% ⭐ 82.52% ⭐ -3.25% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

0 participants