ProgressBar_Enhancement #1613
Merged
ProgressBar_Enhancement #1613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ahmednasr95
commented
May 14, 2024
ahmednasr95
commented
- Fixed the repetitive logging during failed assertion
- Added a new logger to the log4j2.properties to be able to print the progress bar on the console
- Added the progress bar to indicate the time elapsed since start of assertion
* Added a new logger to the log4j2.properties to be able to print the progress bar on the console * Added the progress bar to indicate the time elapsed since start of assertion
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1613 +/- ##
=============================================
- Coverage 54.31% 24.32% -30.00%
+ Complexity 1377 633 -744
=============================================
Files 111 112 +1
Lines 9982 10012 +30
Branches 969 971 +2
=============================================
- Hits 5422 2435 -2987
- Misses 3947 7152 +3205
+ Partials 613 425 -188 ☔ View full report in Codecov by Sentry. |
|
@MohabMohie @MahmoudElSharkawy |
MohabMohie
requested changes
May 23, 2024
There was a problem hiding this comment.
Thank you for an excellent implementation, and kindly find my comments inline.
regarding the virtual threads, kindly tag @MustafaAgamy via Slack and he'll be happy to help.
| @@ -97,7 +97,7 @@ public static String convertBase64(String text) { | |||
| */ | |||
| public static int compareTwoObjects(Object expectedValue, Object actualValue, Object comparisonType, | |||
| Boolean validationType) { | |||
| ReportManager.logDiscrete("Expected \"" + expectedValue + "\", and actual \"" + actualValue + "\""); | |||
| //ReportManager.logDiscrete("Expected \"" + expectedValue + "\", and actual \"" + actualValue + "\""); | |||
There was a problem hiding this comment.
instead of commenting this line, kindly log it using DEBUG level.
There was a problem hiding this comment.
I tried to logging using the DEBUG level but to no avail. As shown in the screenshot below, The message is still logged to the console as an INFO.
src/main/java/com/shaft/validation/internal/ValidationsHelper2.java
Outdated
Show resolved
Hide resolved
src/main/java/com/shaft/tools/io/internal/ReportManagerHelper.java
Outdated
Show resolved
Hide resolved
…e condition. * Returned the google search test cases to their initial state * Added a virtual thread class that can be used to create virtual threads which assist in performing small tasks
Signed-off-by: Ahmed Nasr <[email protected]>
…n the `ValidationsExecutor` class. * Moved the stop thread method to after the switch statement mentioned above.
…rogress_Bar_Enhancement
…m the log4j.properties file but to no avail * This commit can be used to help in debugging the issue from multiple points of view.
…r logger is abstracted from the log4j2.properties file. * The virtual thread setup and tear-down are returned to the ValidationsHelper2 because: 1. The progress bar is needed only when a fluent wait is running. 2. The progress bar logger configured just before the progress bar starts doesn't log into the external log file. 3. Since the virtual thread tear-down is called after the switch statement, all information logged before that point is not logged into the log file which is undesirable behavior. The aforementioned issue occurs only when the element being validated passes the validation after some time.
Signed-off-by: Mohab Mohie <[email protected]>
MohabMohie
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.