[MathPow] Added Favorite Templates #93
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaanCoding
reviewed
May 6, 2024
|
|
||
| export default function IndexPage() { | ||
| const [template, setTemplates] = useState<ITemplate[]>([]) | ||
| const [pageType, setPageType] = useState<IPageType>(IPageType.NONE) | ||
|
|
||
| function getTemplateId(template: ITemplate): string { |
There was a problem hiding this comment.
16-64, This code can most likely be split up into a helper function, so it's easier to refactor and not as tightly coupled within the application. getSortedTemplatesByFavorite makes sense to stay here though if you want. unless you make a functional map component.
I would move this to /frontend/utils
There was a problem hiding this comment.
Also for me to test later: What happens if the key isn't valid i.e. template with key no longer exists
There was a problem hiding this comment.
Good idea. I will move it there later this week thanks
ShaanCoding
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#77
I chose to add a heart icon that is full if the tempalte is in favorite. All of the informations for this is stored in local storage. The card on sorted by favorite for now. We could change this when we have a favorite tag in the search system. If nothing is liked, nothing changes.
@ShaanCoding, Write me if you thought of a specific style or placement that you wanted for the icon. Maybe you like white more so it blends in more, I wasn't sure about this.